Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #13106 by adding TargetTransformInfoWrapperPass to pass list. #13349

Merged
merged 1 commit into from
Sep 29, 2015

Conversation

ArchRobison
Copy link
Contributor

This PR fixes issue #13106.

LLVM 3.7 seems to introduce the pass normally via function addPassesToGenerateCode, which is called by addPassesToEmitMC, which are both defined in lib/CodeGen/LLVMTargetMachine.cpp. If LLVM >=3.7 ever becomes our default version of LLVM, we should study that code more closely to see if we should be calling it instead of just inserting createTargetTransformInfoWrapperPass into the pass list.

@vtjnash
Copy link
Member

vtjnash commented Sep 29, 2015

addPassesToEmitMC is called by MCJIT (deps/llvm-3.7.0/lib/ExecutionEngine) to emit the code, so i think the issue is that we needed to call this particular pass earlier (as you do here), and not that we need to call all of addPassesToEmitMC

vtjnash added a commit that referenced this pull request Sep 29, 2015
Fix issue #13106 by adding TargetTransformInfoWrapperPass to pass list.
@vtjnash vtjnash merged commit bc1a8f5 into JuliaLang:master Sep 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants